Skip to content

fix: link to attachToDocument definition #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

sarahdayan
Copy link
Contributor

This PR links to the definition of attachToDocument, bringing clarification to users who might be confused by it when reading up the wrapper properties.

Note: I couldn't edit the Japanese, Chinese and Russian docs as I'm not able to identify where to put the link.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Documentation update.

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. Definitely need a good way to notify translators of changes...

@lmiller1990 lmiller1990 merged commit 775feb7 into vuejs:dev Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants